0000936: Oracle integer datatype has a larger precision than the java…

… Integer datatype.
JumpMind · Dec 1, 2012 · 9fc4989 · 9fc4989
1 parent a73efb4
commit 9fc4989
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/symmetric-db/src/main/java/org/jumpmind/db/platform/AbstractDatabasePlatform.java b/symmetric-db/src/main/java/org/jumpmind/db/platform/AbstractDatabasePlatform.java
@@ -25,6 +25,7 @@
 import java.io.InputStream;
 import java.io.InputStreamReader;
 import java.math.BigDecimal;
+import java.math.BigInteger;
 import java.sql.Array;
 import java.sql.Timestamp;
 import java.sql.Types;
@@ -393,7 +394,11 @@ public Object[] getObjectValues(BinaryEncoding encoding, String[] values,
     }
 
     protected Number parseIntegerObjectValue(String value) {
-        return Integer.parseInt(value);
+        try {
+            return Integer.parseInt(value);
+        } catch (NumberFormatException ex) {
+            return new BigInteger(value);        
+        }
     }
 
     // TODO: this should be AbstractDdlBuilder.getInsertSql(Table table,

diff --git a/symmetric-jdbc/src/main/java/org/jumpmind/db/platform/oracle/OracleDatabasePlatform.java b/symmetric-jdbc/src/main/java/org/jumpmind/db/platform/oracle/OracleDatabasePlatform.java
@@ -19,8 +19,6 @@
  * under the License.
  */
 
-import java.math.BigInteger;
-
 import javax.sql.DataSource;
 
 import org.apache.commons.lang.StringUtils;
@@ -78,12 +76,10 @@ protected OracleJdbcSqlTemplate createSqlTemplate() {
         SymmetricLobHandler symmetricLobHandler = new SymmetricLobHandler(lobHandler);
         return new OracleJdbcSqlTemplate(dataSource, settings, symmetricLobHandler, getDatabaseInfo());
     }
-
-    @Override
-    protected Number parseIntegerObjectValue(String value) {
-        return new BigInteger(value);
+    public static void main(String[] args) {
+        System.out.println(Integer.MAX_VALUE);
     }
-
+    
     public String getName() {
         return DatabaseNamesConstants.ORACLE;
     }