0002103 - Remove auto increment attribute as part of table creation f…

…or identity columns that are not part of the PK for databases that do not support it.
JumpMind · Dec 16, 2014 · bbd0634 · bbd0634
1 parent 377f247
commit bbd0634
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/symmetric-db/src/main/java/org/jumpmind/db/platform/AbstractDatabasePlatform.java b/symmetric-db/src/main/java/org/jumpmind/db/platform/AbstractDatabasePlatform.java
@@ -830,5 +830,19 @@ public Database readDatabaseFromXml(InputStream is, boolean alterCaseToMatchData
     public boolean canColumnBeUsedInWhereClause(Column column) {
         return true;
     }
+
+    @Override
+    public void makePlatformSpecific(Database database) {
+        Table[] tables = database.getTables();
+        for (Table table : tables) {
+            for (Column autoIncrementColumn : table.getAutoIncrementColumns()) {
+                if (!autoIncrementColumn.isPrimaryKey() && !getDatabaseInfo().isNonPKIdentityColumnsSupported()) {
+                    log.info("Removing auto increment from table " + table.getName() + " for column " + autoIncrementColumn.getName() + 
+                        " since it was not part of primary key and not supported on this database based on nonPKIdentityColumnsSupported.");
+                    autoIncrementColumn.setAutoIncrement(false);
+                }
+            }
+        }
+    }
 
 }
diff --git a/symmetric-db/src/main/java/org/jumpmind/db/platform/IDatabasePlatform.java b/symmetric-db/src/main/java/org/jumpmind/db/platform/IDatabasePlatform.java
@@ -177,4 +177,6 @@ public Object[] getObjectValues(BinaryEncoding encoding, String[] values,
 
     public boolean canColumnBeUsedInWhereClause(Column column);
 
+    public void makePlatformSpecific(Database database);
+
 }
diff --git a/symmetric-io/src/main/java/org/jumpmind/symmetric/io/data/writer/DefaultDatabaseWriter.java b/symmetric-io/src/main/java/org/jumpmind/symmetric/io/data/writer/DefaultDatabaseWriter.java
@@ -501,7 +501,9 @@ protected boolean create(CsvData data) {
             if (writerSettings.isCreateTableAlterCaseToMatchDatabaseDefault()) {
                 platform.alterCaseToMatchDatabaseDefaultCase(db);
             }
-
+
+            platform.makePlatformSpecific(db);
+
             if (writerSettings.isAlterTable()) {
                 platform.alterDatabase(db, !writerSettings.isCreateTableFailOnError());
             } else {