From eae74cfe9d94200ea209e0f19cf4ea7aec7d0443 Mon Sep 17 00:00:00 2001 From: chenson42 Date: Tue, 28 Feb 2012 13:28:53 +0000 Subject: [PATCH] give better error for user if transform_point has an invalid value. --- .../symmetric/service/impl/TransformService.java | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/symmetric/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/TransformService.java b/symmetric/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/TransformService.java index 57915ca2d8..0ed6ddb3f3 100644 --- a/symmetric/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/TransformService.java +++ b/symmetric/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/TransformService.java @@ -1,6 +1,7 @@ package org.jumpmind.symmetric.service.impl; import java.util.ArrayList; +import java.util.Arrays; import java.util.HashMap; import java.util.List; import java.util.Map; @@ -173,7 +174,8 @@ public void saveTransformTable(TransformTableNodeGroupLink transformTable) { } protected void deleteTransformColumns(ISqlTransaction transaction, String transformTableId) { - transaction.prepareAndExecute(getSql("deleteTransformColumnsSql"), (Object) transformTableId); + transaction.prepareAndExecute(getSql("deleteTransformColumnsSql"), + (Object) transformTableId); } public void deleteTransformTable(String transformTableId) { @@ -181,7 +183,8 @@ public void deleteTransformTable(String transformTableId) { try { transaction = sqlTemplate.startSqlTransaction(); deleteTransformColumns(transaction, transformTableId); - transaction.prepareAndExecute(getSql("deleteTransformTableSql"), (Object) transformTableId); + transaction.prepareAndExecute(getSql("deleteTransformTableSql"), + (Object) transformTableId); refreshCache(); transaction.commit(); } finally { @@ -231,9 +234,12 @@ public TransformTableNodeGroupLink mapRow(Row rs) { table.setTargetSchemaName(rs.getString("target_schema_name")); table.setTargetTableName(rs.getString("target_table_name")); try { - table.setTransformPoint(TransformPoint.valueOf(rs.getString("transform_point").toUpperCase())); + table.setTransformPoint(TransformPoint.valueOf(rs.getString("transform_point") + .toUpperCase())); } catch (RuntimeException ex) { - log.warn("Invalid value provided for transform_point: {}", rs.getString("transform_point")); + log.warn( + "Invalid value provided for transform_point of '{}.' Valid values are: {}", + rs.getString("transform_point"), Arrays.toString(TransformPoint.values())); throw ex; } table.setTransformOrder(rs.getInt("transform_order"));