From f19561905cc83ee2cc899ada97e38f252ba254ac Mon Sep 17 00:00:00 2001 From: Philip Marzullo Date: Thu, 22 Sep 2022 14:23:22 -0400 Subject: [PATCH] 0005466: Push registration, when sync URL is empty for registering node, should allow Pull registration to recover from empty sync URL --- .../symmetric/service/impl/RegistrationService.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/RegistrationService.java b/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/RegistrationService.java index 973861b352..378fcbd753 100644 --- a/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/RegistrationService.java +++ b/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/RegistrationService.java @@ -308,8 +308,12 @@ public boolean registerNode(Node nodePriorToRegistration, String remoteHost, nodePriorToRegistration, remoteHost, remoteAddress) : nodePriorToRegistration.getNodeId(); NodeSecurity nodeSecurity = nodeService.findNodeSecurity(nodeId); if (nodeSecurity != null && nodeSecurity.isRegistrationEnabled()) { - log.debug("Pull of registration from {} is being ignored because group link is push", nodePriorToRegistration); - return true; + // Make sure sync URL is set before skipping this registration request + Node node = nodeService.findNode(nodeId); + if (node != null && node.getSyncUrl() != null && node.getSyncUrl().length() > 0) { + log.debug("Pull of registration from {} is being ignored because group link is push", nodePriorToRegistration); + return true; + } } } }