Navigation Menu

Skip to content

Commit

Permalink
Dev: [fix] html editor URL
Browse files Browse the repository at this point in the history
  • Loading branch information
Shnoulle committed Jun 21, 2015
1 parent 46fe201 commit 1456edf
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions application/views/layouts/survey.php
Expand Up @@ -13,14 +13,14 @@
$cs->registerCssFile(App()->theme->baseUrl . '/css/style.css');

$cs->registerCssFile(App()->params['bower-asset'] . '/select2-bootstrap-css/select2-bootstrap.min.css');
$cs->registerScriptFile('/scripts/ajax.js');
$cs->registerScriptFile('/scripts/unobtrusive.js');
$cs->registerScriptFile(App()->getBaseUrl().'/scripts/ajax.js');
$cs->registerScriptFile(App()->getBaseUrl().'/scripts/unobtrusive.js');

$cs->registerScriptFile(App()->params['bower-asset'] . '/remarkable-bootstrap-notify/bootstrap-notify.min.js');
$cs->registerScriptFile(App()->params['bower-asset'] . '/jquery-ui/jquery-ui.min.js');
App()->getComponent('yiiwheels')->registerAssetJs('bootstrap-bootbox.min.js');
$cs->registerScriptFile(App()->params['bower-asset'] . '/tinymce/tinymce.min.js');
$cs->registerScriptFile('/scripts/htmleditor.js');
$cs->registerScriptFile(App()->getBaseUrl().'/scripts/htmleditor.js');
$cs->registerScript('links', "$('body').on('click', '.disabled a', function (e) { e.preventDefault(); });");
?>
<title>Limesurvey Administration</title>
Expand Down Expand Up @@ -52,4 +52,4 @@

</body>

</html>
</html>
6 changes: 3 additions & 3 deletions scripts/htmleditor.js
Expand Up @@ -4,7 +4,7 @@
'selector' :'textarea.html',
'file_picker_callback' : function(callback, value, meta) {
tinymce.activeEditor.windowManager.open({
file: '/index.php?r=files/manage&dialog=1',
file: LS.data.baseUrl+'/index.php?r=files/manage&dialog=1',
title: 'elFinder',
width: 900,
height: 480,
Expand Down Expand Up @@ -38,7 +38,7 @@

function elFinderBrowser (field_name, url, type, win) {
tinymce.activeEditor.windowManager.open({
file: '/elfinder/elfinder.html',// use an absolute path!
file: LS.data.baseUrl+'/elfinder/elfinder.html',// use an absolute path!
title: 'elFinder 2.0',
width: 900,
height: 450,
Expand All @@ -49,4 +49,4 @@ function elFinderBrowser (field_name, url, type, win) {
}
});
return false;
}
}

5 comments on commit 1456edf

@Shnoulle
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SamMousa : a question about htmleditor an settings. I think ckeditor/core html editor must be in https://github.com/LimeSurvey/LimeSurvey/tree/master/application/extensions , and used in https://github.com/LimeSurvey/LimeSurvey/blob/master/application/extensions/SettingsWidget/SettingsWidget.php#L301 .

Are you OK with that ? or no ?

PS: this fix is a quick fix. elfinder don't work (show , but don't work).

@SamMousa
Copy link
Contributor

@SamMousa SamMousa commented on 1456edf Jun 21, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shnoulle
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, i know : like we include bootstrap, select2 etc .... But i speak for htmleditor.js : think its' better if we don't do different system for core an plugin : https://github.com/LimeSurvey/LimeSurvey/blob/master/application/extensions/SettingsWidget/SettingsWidget.php#L301

Are you OK with this project : https://manual.limesurvey.org/Project_ideas_for_GSoC_2015#Make_use_of_the_SettingsWidget_for_core_functions (not GSOC but LS3 objective).

Actually : when try to upload a file : not json returned and when try to create a file : No creation. But thi i can look further.

@SamMousa
Copy link
Contributor

@SamMousa SamMousa commented on 1456edf Jun 21, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shnoulle
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.