Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
7 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1456edf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SamMousa : a question about htmleditor an settings. I think ckeditor/core html editor must be in https://github.com/LimeSurvey/LimeSurvey/tree/master/application/extensions , and used in https://github.com/LimeSurvey/LimeSurvey/blob/master/application/extensions/SettingsWidget/SettingsWidget.php#L301 .
Are you OK with that ? or no ?
PS: this fix is a quick fix. elfinder don't work (show , but don't work).
1456edf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1456edf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, i know : like we include bootstrap, select2 etc .... But i speak for htmleditor.js : think its' better if we don't do different system for core an plugin : https://github.com/LimeSurvey/LimeSurvey/blob/master/application/extensions/SettingsWidget/SettingsWidget.php#L301
Are you OK with this project : https://manual.limesurvey.org/Project_ideas_for_GSoC_2015#Make_use_of_the_SettingsWidget_for_core_functions (not GSOC but LS3 objective).
Actually : when try to upload a file : not json returned and when try to create a file : No creation. But thi i can look further.
1456edf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1456edf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussion opened : https://bugs.limesurvey.org/view.php?id=9704