From 311b4532daba59bd6096b4481b851288acc5288b Mon Sep 17 00:00:00 2001 From: Gabriel Jenik Date: Fri, 2 Oct 2020 06:30:36 -0300 Subject: [PATCH] Fixed issue #16672: Can't select seperator for CPDB export - export doesn't recognise text (#1600) Used 'fputcsv' in CPDBExport() with default args --- application/helpers/export_helper.php | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/application/helpers/export_helper.php b/application/helpers/export_helper.php index b8316939a92..904be330c6c 100644 --- a/application/helpers/export_helper.php +++ b/application/helpers/export_helper.php @@ -2360,17 +2360,13 @@ function CPDBExport($data, $filename) header("Content-Disposition: attachment; filename=".$filename.".csv"); header("Content-type: text/comma-separated-values; charset=UTF-8"); header("Cache-Control: must-revalidate, no-store, no-cache"); - $tokenoutput = chr(hexdec('EF')).chr(hexdec('BB')).chr(hexdec('BF')); + echo chr(hexdec('EF')).chr(hexdec('BB')).chr(hexdec('BF')); // UTF-8 BOM + $handler = fopen('php://output', 'w'); foreach ($data as $key=>$value) { - foreach ($value as $values) { - $tokenoutput .= trim($values).','; - } - $tokenoutput = substr($tokenoutput, 0, -1); // remove last comma - $tokenoutput .= "\n"; - + fputcsv($handler, $value); } - echo $tokenoutput; + fclose($handler); exit; }