Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Dev: avoid empty values in SRC or URL
- Loading branch information
LouisGac
committed
Apr 9, 2019
1 parent
9d1f0eb
commit 42c1de6
Showing
1 changed file
with
3 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42c1de6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This broke API of template.
I already use
{% if (!imageSrc(processString("{TEMPLATEURL}")~"logo.png) %}
What is the issue before ? You return the same string (
""
) if imageSrc is invalid …42c1de6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes you're right. I'm going to submit another commit that will not break existing custom themes using "false" value.
42c1de6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
none is better than ERROR , or send a 0 and not false to fix backgound url ?
42c1de6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another solution : aSurveyInfo.options.backgroundimage check if it's a valid image to set to on ?