Fixed issue #18140: cannot import vv file (with debug set) (#2453)

Dev: remove uneeded unlink and add comment in function
LimeSurvey · Jun 6, 2022 · 4bea7d6 · 4bea7d6
1 parent c1fe0dc
commit 4bea7d6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/application/controllers/admin/dataentry.php b/application/controllers/admin/dataentry.php
@@ -144,7 +144,6 @@ private function _handleFileUpload($iSurveyId, $aData)
         $aOptions['sCharset'] = Yii::app()->request->getPost('vvcharset');
         $aOptions['sSeparator'] = "\t";
         $aResult = CSVImportResponses($filePath, $iSurveyId, $aOptions);
-        unlink($filePath); //delete the uploaded file
         $aData['class'] = "";
         $aData['title'] = gT("Import a VV response data file");
         $aData['aResult']['success'][] = gT("File upload succeeded.");

diff --git a/application/helpers/admin/import_helper.php b/application/helpers/admin/import_helper.php
@@ -1878,6 +1878,7 @@ function XMLImportResponses($sFullFilePath, $iSurveyID, $aFieldReMap = array())
 
 /**
 * This function imports a CSV file into the response table
+* csv file is deleted during process
 *
 * @param string $sFullFilePath
 * @param integer $iSurveyId
@@ -2780,6 +2781,7 @@ function createXMLfromData($aData = array()){
 
 /**
  * Read a csv file and resturn a tmp ressources to same file in utf8
+ * csv file is deleted during process
  * @param string $fullfilepath
  * @param string $encoding from
  * @return resource