From 74f38533bf24fba3a6989f71b907ccb66fe2a67d Mon Sep 17 00:00:00 2001 From: Olle Haerstedt Date: Wed, 24 Feb 2021 16:06:07 +0100 Subject: [PATCH] Dev: It's OK to use 0777 (see note) --- .../libraries/ExtensionInstaller/FileFetcherUploadZip.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/application/libraries/ExtensionInstaller/FileFetcherUploadZip.php b/application/libraries/ExtensionInstaller/FileFetcherUploadZip.php index fca3f08ae68..df8dd9de3ff 100644 --- a/application/libraries/ExtensionInstaller/FileFetcherUploadZip.php +++ b/application/libraries/ExtensionInstaller/FileFetcherUploadZip.php @@ -59,8 +59,8 @@ public function move($destdir) throw new Exception(gT('Temporary folder does not exist.')); } - // TODO: Correct permission? - mkdir($destdir, 0760, true); + // NB: mkdir() always applies the set umask to 0777. See https://www.php.net/manual/en/function.mkdir + mkdir($destdir, 0777, true); if (!is_writable(dirname($destdir))) { throw new Exception(gT('Cannot move files due to permission problem. ' . $destdir));