From 4d80388ea4fc7dbb71cad6ae736fb1429ab576a2 Mon Sep 17 00:00:00 2001 From: Denis Chenu Date: Mon, 9 Nov 2015 11:12:15 +0100 Subject: [PATCH] Fixed issue #10001: Relevance equation on different group not working with decimal values Dev: quick fix in JS, must be done in PHP only of different group in EM --- scripts/expressions/em_javascript.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/expressions/em_javascript.js b/scripts/expressions/em_javascript.js index af2f52805cd..c554894ca1a 100644 --- a/scripts/expressions/em_javascript.js +++ b/scripts/expressions/em_javascript.js @@ -461,6 +461,7 @@ function LEMval(alias) if (LEMradix === ',') { newval = str.split(',').join('.'); } + if (newval == parseFloat(newval)) { if (newval.length > 0 && newval[0]==0) { return newval; // so keep 0 prefixes on numbers @@ -485,12 +486,14 @@ function LEMval(alias) } } var whichJsName; // correct name whether on- or off-page + if (LEMmode=='survey' || (LEMmode=='group' && attr.gseq == LEMgseq) || (LEMmode=='question' && attr.qid == LEMqid)) { whichJsName = (typeof attr.jsName_on === 'undefined') ? attr.jsName : attr.jsName_on; } else { whichJsName = attr.jsName; } + if (whichJsName === null || typeof document.getElementById(whichJsName) === 'undefined' || document.getElementById(whichJsName) === null) { an_error = true; // this line is here to make debugging easier return ''; @@ -673,7 +676,7 @@ function LEMval(alias) { return ""; } - if (LEMradix === ',') { + if (LEMgseq==attr.gseq && LEMradix === ',' ) { var regValidateNum = /^-?\d*\,?\d*$/; }else{ var regValidateNum = /^-?\d*\.?\d*$/;