Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Fixed issue #18026: Session expire message when submit button is clic…
…ked twice (#2353)
- Loading branch information
1 parent
a75c3f4
commit 8082779
Showing
1 changed file
with
25 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8082779
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://bugs.limesurvey.org/view.php?id=18096
8082779
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another one : https://bugs.limesurvey.org/view.php?id=18098
8082779
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, not good. @gabrieljenik Please add automatic integrity tests for all issues related to this regression. To both LS3 and LS5, if possible (LS5 has priority).
8082779
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really think we need only LS5 test, no ?
8082779
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, maybe
8082779
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All those maybe fixed here?
https://bugs.limesurvey.org/view.php?id=18074
8082779
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, the bug could have been avoided if we started to use Flow on vanilla JS. It doesn't allow to make assumptions on if something is undefined/null or not, so you're forced to do more checking/defensive programming.
https://flow.org/