From 88a9a2854a53c53ea16a34d394f897000a4e7af2 Mon Sep 17 00:00:00 2001
From: GabrielJenik <gabriel.jenik@gmail.com>
Date: Thu, 1 Oct 2020 09:41:10 -0300
Subject: [PATCH] Fixed issue #16694: Export multiple surveys (lss, lsa) to ZIP
 crashes or does not export reports/tokens for correct survey

In 'buildXMLFromQuery', the survey ID is needed for response and token decryption.
It was being derived from session. which worked when exporting a single survey info, or from within a survey. Now an optional parameter was added so the ID can be specified by the caller.
---
 application/helpers/export_helper.php | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/application/helpers/export_helper.php b/application/helpers/export_helper.php
index 904be330c6c..8b32cb5d789 100644
--- a/application/helpers/export_helper.php
+++ b/application/helpers/export_helper.php
@@ -708,7 +708,7 @@ function SPSSGetQuery($iSurveyID, $limit = null, $offset = null)
 * @param string $tagname  If the XML tag of the resulting question should be named differently than the table name set it here
 * @param string[] $excludes array of columnames not to include in export
 */
-function buildXMLFromQuery($xmlwriter, $Query, $tagname = '', $excludes = array())
+function buildXMLFromQuery($xmlwriter, $Query, $tagname = '', $excludes = array(), $iSurveyID = 0)
 {
     $iChunkSize = 3000; // This works even for very large result sets and leaves a minimal memory footprint
 
@@ -731,9 +731,9 @@ function buildXMLFromQuery($xmlwriter, $Query, $tagname = '', $excludes = array(
             $criteria->limit = $iChunkSize;
             $criteria->offset = $iStart;
             if ($TableName == 'responses'){
-                $results = Response::model(Yii::app()->session['LEMsid'])->findAll($criteria);
+                $results = Response::model($iSurveyID)->findAll($criteria);
             } elseif ($TableName == 'tokens'){
-                $results = Token::model(Yii::app()->session['LEMsid'])->findAll($criteria);
+                $results = Token::model($iSurveyID)->findAll($criteria);
             }
 
             foreach($results as $row){
@@ -1009,7 +1009,7 @@ function getXMLDataSingleTable($iSurveyID, $sTableName, $sDocType, $sXMLTableTag
     $xml->endElement();
     $aquery = "SELECT * FROM {{{$sTableName}}}";
 
-    buildXMLFromQuery($xml, $aquery, $sXMLTableTagName);
+    buildXMLFromQuery($xml, $aquery, $sXMLTableTagName, array(), $iSurveyID);
     $xml->endElement(); // close columns
     $xml->endDocument();
     if ($sFileName = '') {