Fixed issue #16966: No way to edit role Permission

Dev: fix the freeze
LimeSurvey · Jan 12, 2021 · a0f5c6f · Shnoulle · Jan 14, 2021 · a0f5c6f
1 parent bec30ad
commit a0f5c6f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/application/models/Permission.php b/application/models/Permission.php
@@ -539,7 +539,7 @@ public function hasPermission($iEntityID, $sEntityName, $sPermission, $sCRUD = '
 
         /* Always return true if you are the owner : this can be done in core plugin ? */
         // TODO: give the rights to owner adding line in permissions table, so it will return true with the normal way
-        if ($iUserID == $this->getEntityOwnerId($iEntityID, $sEntityName) && $sEntityName != 'role') {
+        if ($iUserID == $this->getEntityOwnerId($iEntityID, $sEntityName)) {
             return true;
         }
 
@@ -764,7 +764,7 @@ public static function getUserRole($iUserID)
     protected function getEntityOwnerId($iEntityID, $sEntityName)
     {
         /* know invalid entity */
-        if (in_array($sEntityName, array('global','template'))) {
+        if (in_array($sEntityName, array('global','template','role',))) {
             return null;
         }
         /* allow to get it dynamically from any model */