Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Fixed issue #13315: Make it possible to submit mandatory multiple cho…
…ice with empty comment
  • Loading branch information
olleharstedt committed Feb 8, 2018
1 parent e0bba52 commit a668683
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion assets/scripts/multiplechoice_withcomments.js
Expand Up @@ -18,7 +18,8 @@ var doMultipleChoiceWithComments = function(qID,when)
question.on('keyup focusout',':not(.other-item) input:text',function(event){
var checkboxinput=$("#answer"+$(this)[0].name.replace("comment",""));
if($(this)[0].value==""){
checkboxinput[0].checked=false;
// Do nothing in this case - if the question is mandatory, it should still be possible to
// submit a checked box without a comment.
}else{
checkboxinput[0].checked=true;
}
Expand Down

4 comments on commit a668683

@LouisGac
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this going to change the default behavior of running surveys...
I'm not sure we should do that...

@olleharstedt
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order by @c-schmitz

@olleharstedt
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the behaviour on 2.73.

@LouisGac
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Please sign in to comment.