Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
New feature: Option to reverse the slider direction.
- Loading branch information
Showing
3 changed files
with
25 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ada599e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's really nice. Does it fix the RTL problem?
ada599e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. What RTL problem?
ada599e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slider was working in the wrong direction in RTL mode
ada599e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... the slider direction is the same in RTL but the Min/Max texts are reversed. I'm hesitant to reverse the slider direction because it will mess with the vertical sliders. I suppose we could adjust the "pull-xx" class here depending on language direction (if I knew how to detect it :) ) - ada599e#diff-0e2b0985e0ef0b94f3155723696faaffR66.
Also, I don't see the Left/Right texts rendered at all in RTL.
ada599e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issue with rtl and default template at a time around 2016-12-22 pull done.
http://testing.sondages.pro/answershtml/index.php/48422/lang/ar
boostrap-rtl package fix this without any issue.
ada599e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LouisGac What is the issue in rtl ? Before holiday, it work in develop.
ada599e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think rtl is unrelated here : rtl are borken before this fix
in 2.5X or 3.0 : rtl must be inverse (0 at start : then right, not left like currently) by default. If is set 'inverse' (after this new attribute) : shown ltr if rtl and rtl for ltr.
But : i think it'"s must be done only with js/css, not in HTML.
ada599e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shnoulle, I fixed it in the HTML rendering - 505d05f
ada599e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, i see this : but