Dev: Don't load plugins that are not compatible

LimeSurvey · Sep 28, 2021 · de93dab · de93dab
1 parent 83578af
commit de93dab
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/application/libraries/PluginManager/PluginManager.php b/application/libraries/PluginManager/PluginManager.php
@@ -5,6 +5,7 @@
 use Yii;
 use Plugin;
 use ExtensionConfig;
+use Exception;
 
 /**
  * Factory for limesurvey plugin objects.
@@ -316,7 +317,7 @@ public function scanPlugins($includeInstalledPlugins = false)
                                     if (!$saveResult) {
                                         // This only happens if database save fails.
                                         $this->shutdownObject->disable();
-                                        throw new \Exception(
+                                        throw new Exception(
                                             'Internal error: Could not save load error for plugin ' . $pluginName
                                         );
                                     }
@@ -434,7 +435,11 @@ public function loadPlugin($pluginName, $id = null)
                 }
             } else {
                 if (!isset($this->plugins[$id]) || get_class($this->plugins[$id]) !== $pluginName) {
-                    if ($this->getPluginInfo($pluginName) !== false) {
+                    $pluginInfo = $this->getPluginInfo($pluginName);
+                    if ($pluginInfo !== false) {
+                        if (!$pluginInfo['isCompatible']) {
+                            throw new Exception(gT('The plugin is not compatible with your version of LimeSurvey.'));
+                        }
                         if (class_exists($pluginName)) {
                             $this->plugins[$id] = new $pluginName($this, $id);
                             if (method_exists($this->plugins[$id], 'init')) {
@@ -460,7 +465,7 @@ public function loadPlugin($pluginName, $id = null)
             if (!$saveResult) {
                 // This only happens if database save fails.
                 $this->shutdownObject->disable();
-                throw new \Exception(
+                throw new Exception(
                     'Internal error: Could not save load error for plugin ' . $pluginName
                 );
             }