Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make source tree easier to use by converting files to UTF-8 format #1406

Closed
Maximus5 opened this issue Jul 31, 2015 · 5 comments
Closed

Make source tree easier to use by converting files to UTF-8 format #1406

Maximus5 opened this issue Jul 31, 2015 · 5 comments
Assignees

Comments

@Maximus5
Copy link
Owner

Originally reported on Google Code with ID 1406

OS version: Win7   SP1   x64
ConEmu version: 131219 x64
Far version (if you are using Far Manager): None

ConEmu source files using codepage 1251 are not automatically detected on US English
and many other localizations of Visual Studio.  As a result, comments in Cyrillic are
not easily corrected displayed.

In the interest of internationalization, a simple script can be run over the source
tree to convert files from 1251 to utf-8.

Attached is an example script to perform the change automatically.

After the change a number of other minor steps need to be performed to make the project
build again.  A trial conversion has been done in this git branch which provides an
example of what things have to change:

https://github.com/ricksladkey/ConEmu/commits/develop

Reported by rick.sladkey on 2013-12-24 04:30:11


- _Attachment: [fix-cyrillic.sh](https://storage.googleapis.com/google-code-attachments/conemu-maximus5/issue-1406/comment-0/fix-cyrillic.sh)_
@Maximus5
Copy link
Owner Author

You have added ".editorconfig" file in the root directory.
Why?
May be "arc" folder is better location?
What applications uses it?

Reported by ConEmu.Maximus5 on 2013-12-24 11:26:10

@Maximus5 Maximus5 self-assigned this Jul 31, 2015
@Maximus5
Copy link
Owner Author

Damn autocorrection...
"src" folder of course

Reported by ConEmu.Maximus5 on 2013-12-24 11:26:59

@Maximus5
Copy link
Owner Author

The file .editorconfig file is used by EditorConfig plugins for Vim, Emacs, Visual Studio,
etc. to ensure that edits to the files follow the proper coding style for the project.
 I put it in the root because there are text files in the Release folder but perhaps
src is better.

I used to use tabs for all my projects but nowadays it seems spaces are more popular
so my default Visual Studio settings are to insert spaces.  Unless I remember to turn
off inserting spaces, when I edit a ConEmu source file, my changes will not follow
the coding style of the project.  As a result, I use the Visual Studio EditorConfig
Extension (https://github.com/jedmao/editorconfig-visualstudio/tree/enforce/Dist) to
ensure that I follow ConEmu coding style when editing ConEmu source files without having
to adjust my default settings.  Similar plugins for Vim, Emacs, etc. accomplish the
same result for those editors.

Reported by rick.sladkey on 2013-12-24 20:24:52

@Maximus5
Copy link
Owner Author

In the branch "daily" with some modifications

Reported by ConEmu.Maximus5 on 2013-12-25 19:11:38

  • Status changed: Done

@Maximus5
Copy link
Owner Author

Thanks, tested and working great.

Reported by rick.sladkey on 2013-12-27 04:48:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant