New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix five debugger issues #3561
fix five debugger issues #3561
Conversation
Oh wow, this is great! |
@cartermp You (or someone else) might want to step the TheBigFileOfDebugStepping.fsx on .NET Core, just to check things are ok. Also in VSCode/Ionide. I compile using |
A horrible number of test baselines needed updating about 150 files |
Ugh, I can't test anything. Nothing will build on my machine with { 15.3.3, VSSDK, Win10 SDK, F# support }, after a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ... you've been busy.
Okay, I got it to build after uninstalling nightlies and using VS command prompt in admin mode. Not sure which of that fixed it. Argh. Anyways, I can test this this week |
@dotnet-bot test this |
Well, I updated about 250 code generation test files (and simplified the naming of some others). I took a look through as many of these as I could and basically all seemed to be the 'nop' removal. For example this one clearly has had one opode removed. It's possible that something is being hidden by such a large test update. But I think it's still ready for merge, there's not a l;ot more we can do here besides staring at the diffs and manual testing. |
@KevinRansom I think we may as well merge this - review welcome for the src\fsharp files |
I already looked, I forgot to approve ... sorry. |
@KevinRansom You did approve, I just didn't notice it |
This fixes three debugging issues
There were two other issues fixed along the way
let rec
did not have a sequence point placed. That is fixed.printfn "..." a b
, the allocation of the format string was done prior to the printf. That could cause odd step-through behaviour.The changes are
Testing is mostly through codegen tests - nearly all will need to be updated because along the way a
nop
instruction has disappeared from the top of most methods, because of the fix to #92 . I've also updated TheBigFileOfDebugStepping.fsx with new examples and manually done step-through for the whole file.