Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdfstudio: init at 2021.1.1 #151287

Merged
merged 2 commits into from Dec 21, 2021
Merged

pdfstudio: init at 2021.1.1 #151287

merged 2 commits into from Dec 21, 2021

Conversation

PhilippWoelfel
Copy link
Contributor

Motivation for this change

Adds package for the commercial software PDF Studio, which is a feature rich PDF editor and viewer.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@markuskowa markuskowa self-assigned this Dec 19, 2021
markuskowa
markuskowa requested changes Dec 19, 2021
View reviewed changes
Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice to see this packaged.

pkgs/applications/misc/pdfstudio/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/pdfstudio/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/pdfstudio/pdfstudio.desktop Outdated Show resolved Hide resolved
markuskowa
markuskowa reviewed Dec 20, 2021
View reviewed changes
Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That looks good now. One last thing: please squash the commits, so that we have only two:

  • maintainers: add pwoelfel
  • pdfstudio: init at 2021.1.1

@markuskowa markuskowa merged commit ddbdf98 into NixOS:master Dec 21, 2021
@PhilippWoelfel PhilippWoelfel deleted the submit/pdfstudio-init branch December 30, 2021 07:15
@koppor
Copy link
Contributor

koppor commented Jan 29, 2024

For the googlers, find all package variants at https://search.nixos.org/packages?channel=unstable&from=0&size=50&sort=relevance&type=packages&query=pdfstudio

nix-shell -p pdfstudio2023

gives you a shell with pdfstudio, where you can run pdfstudio2023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa approved these changes

Assignees

@markuskowa markuskowa

Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PhilippWoelfel @koppor @markuskowa @Janik-Haag