gourou: init at 0.7.2 #179678
gourou: init at 0.7.2 #179678
Conversation
| new file mode 100644 | ||
| index 000000000000..cdfdc04d0bb1 | ||
| --- /dev/null | ||
| +++ b/include/base64.h |
There was a problem hiding this comment.
This is not a patch, it is a file inclusion disguised as patch.
Why?
There was a problem hiding this comment.
Because it's a gist fetched at build time otherwise. I also sent the same patch upstream.
There was a problem hiding this comment.
Since it is a gist, you can just fetch it using fetchgit or even with fetchzip (by using https://gist.github.com/<username>/<gist>/archive/<commit>.zip) instead of doing this. Them just copy it after the unpackPhase inside the build directory.
This will avoid committing a big "patch" inside nixpkgs repository, and also will allow tracking of its origins better.
| src = fetchgit { | ||
| url = "git://soutade.fr/updfparser"; | ||
| rev = "9d56c1d0b1ce81aae4c8db9d99a8b5d1f7967bcf"; | ||
| sha256 = "sha256-9dvibKiUbbI4CrmuAaJzlpntT0XdLvdGeC2/WzjlA5U="; |
There was a problem hiding this comment.
Fix the indentation and also the download hashes.
There was a problem hiding this comment.
I fixed the indentation, but regarding the hashes, it's a bit more complicated than that:
$ nix hash to-sri --type sha256 \
`nix-prefetch-git git://soutade.fr/updfparser \
9d56c1d0b1ce81aae4c8db9d99a8b5d1f7967bcf \
2> /dev/null | jq -r .sha256`
sha256-9dvibKiUbbI4CrmuAaJzlpntT0XdLvdGeC2/WzjlA5U=I am clueless why the CI got different values.
|
Failing on Darwin. Add |
|
Thanks, done.
|
| */ | ||
| #include <string.h> | ||
|
|
||
| -#include <base64/Base64.h> |
There was a problem hiding this comment.
Couldn't you just copy the base64 file in $sourceRoot/include/base64/Base64.h instead?
If this works, this would allow us to drop a patch.
| sha256 = "sha256-jvvfrCuRggSPk7p/WtEaKRV7kILuZjUB1KEgaE4LStc="; | ||
| }; | ||
|
|
||
| postUnpack = '' |
There was a problem hiding this comment.
I know I said post unpack, but I meant post unpack phase for any phase post unpack, not necessary the postUnpack phase.
Actually this looks more like to be a postPatch or preBuild phases, instead of postUnpack (since this isn't unpacking anything).
stale
bot
added
the
2.status: stale
|
Fixed by #222537. |
Description of changes
libgourou is a library for deDRM'ing Adobe ebooks. It's working pretty well for me to download and read comics bought from Kobo offline without using any proprietary software.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes