New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libgourou: init at 0.8.1 #222537
libgourou: init at 0.8.1 #222537
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly I don't own any ADEPT DRM protected files, so I can't confirm all binaries are working as intended. The PR looks fine otherwise.
This can easily be tested with adobe's free sample books # Use an anonymous user and generate .adept folder
adept_activate --anonymous
# Download epub file through acsm
acsmdownloader ~/Downloads/URLLink.acsm
# Remove DRM
adept_remove The\ Adventures\ of\ Sherlock\ Holmes.epub
# Next remove will fail
adept_remove The\ Adventures\ of\ Sherlock\ Holmes.epub |
That works using anonymous activation. |
@thiagokokada |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please introduce each package in separate commits:
updfparser: init at unstable-2023-01-10
libgourou: init at 0.8.1
Thanks for the review @thiagokokada. I've applied all of your suggestions while some look a little different due to my formatter. |
Description of changes
libgourou is a library for removing DRM from Adobe ebooks.
This superseeds the stale #179678 pr, and requires less patches
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)