Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgourou: init at 0.8.1 #222537

Merged
merged 2 commits into from Mar 22, 2023
Merged

libgourou: init at 0.8.1 #222537

merged 2 commits into from Mar 22, 2023

Conversation

sevenautumns
Copy link
Contributor

@sevenautumns sevenautumns commented Mar 22, 2023

Description of changes

libgourou is a library for removing DRM from Adobe ebooks.
This superseeds the stale #179678 pr, and requires less patches

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@dadada dadada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly I don't own any ADEPT DRM protected files, so I can't confirm all binaries are working as intended. The PR looks fine otherwise.

@sevenautumns
Copy link
Contributor Author

sevenautumns commented Mar 22, 2023

Sadly I don't own any ADEPT DRM protected files, so I can't confirm all binaries are working as intended. The PR looks fine otherwise.

This can easily be tested with adobe's free sample books
Here simply download any ebook provided as an acsm file.
(For example "The Adventures of Sherlock Holmes")

# Use an anonymous user and generate .adept folder
adept_activate --anonymous
# Download epub file through acsm
acsmdownloader ~/Downloads/URLLink.acsm
# Remove DRM
adept_remove The\ Adventures\ of\ Sherlock\ Holmes.epub
# Next remove will fail
adept_remove The\ Adventures\ of\ Sherlock\ Holmes.epub

@dadada
Copy link
Contributor

dadada commented Mar 22, 2023

This can easily be tested with adobe's free sample books Here simply download any ebook provided as an acsm file. (For example "The Adventures of Sherlock Holmes")

That works using anonymous activation.

@sevenautumns
Copy link
Contributor Author

sevenautumns commented Mar 22, 2023

@thiagokokada
Since you reviewed the preceding #179678 pr, could I ask for a review of this one as well?

Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please introduce each package in separate commits:

updfparser: init at unstable-2023-01-10
libgourou: init at 0.8.1

@sevenautumns
Copy link
Contributor Author

sevenautumns commented Mar 22, 2023

Thanks for the review @thiagokokada. I've applied all of your suggestions while some look a little different due to my formatter.

@thiagokokada thiagokokada merged commit 49ca35c into NixOS:master Mar 22, 2023
21 of 22 checks passed
@thiagokokada thiagokokada mentioned this pull request Mar 22, 2023
13 tasks
@sevenautumns sevenautumns deleted the libgourou branch August 23, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants