This repository has been archived by the owner on Mar 7, 2019. It is now read-only.
Patch download and extraction of absolute HTTP URIs #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Real-world fetching of an absolute HTTP URI (as you find with zlib for example) leads to an error because the expander is passed the URI instead of the bare name of the downloaded file. This test patch shows this behaviour.
Real-world fetching of an absolute HTTP URI (as you find with zlib for example) leads to an error because the expander is passed the URI instead of the bare name of the downloaded file. This test patch corrects this behaviour.
Minor cosmetics to the get() method: * removed extra empty line * removed stray spaces in empty line * made closing return value consistent with return on line 39
|
This looks good to me! @polettix++ My vote is: Merge: Aye |
|
Agree. aye |
|
I'm having a hard time remembering now if the original behavior was an oversight or by design. What I can imagine is a file whose version comes from its uri path not just its name. For example |
|
sent to CPAN as 0.015_03. I expect to have a production version of this some time this week, assuming nothing bad turns up in cpantesters. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Real-world fetching of an absolute HTTP URI (as you find with zlib for example) leads to an error because the expander is passed the URI instead of the bare name of the downloaded file:
The third commit is an optional cosmetic change that tidies get() up a bit. In particular, the return value at the end has been changed to make it consistent with the return at line 39.
Thanks a lot for Alien::Base!!!