This repository has been archived by the owner on Mar 7, 2019. It is now read-only.
honor alien_provides_* on system install #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The first commit worked on OS X with You can see the failure here: https://travis-ci.org/plicease/Alien-Base/builds/69209383 The second commit makes it work with a real pkg-config. I verified it with a travis branch: https://travis-ci.org/plicease/Alien-Base/builds/69229344 I will update |
Merged
On OS X with PkgConfig.pm it was sufficient to augment the pkg-config output. On Linux with a real pkg-config we need to ignore failures in order to fallback on alien_provides_*
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alien_provides_cflagsandalien_provides_libsaren't honored currently when the library is provided by the system (either with or without pkg-config). This PR will fix that. I have a test for the builder itself. I have tested this withhttps://github.com/plicease/Alien-Libbz2
To ensure that it also works once installed. I will add that to the travis for AB so that we can catch any regressions there.