Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add icons to the instance context menu and 4 new icons #187

Merged
merged 4 commits into from Oct 21, 2022
Merged

add icons to the instance context menu and 4 new icons #187

merged 4 commits into from Oct 21, 2022

Conversation

leia-uwu
Copy link
Contributor

@leia-uwu leia-uwu commented Oct 20, 2022 •
edited

screenshots:
simples (colored icons):
image
simple (light icons):
image
simple (dark icons):
image
simple: (blue icons):
image
osx:
image
ios:
image
flat:
image

leia-uwu and others added 2 commits October 20, 2022 17:48
@leia-uwu
add icons to the instance menu and 4 new icons:
31dc92d 
delete
rename
tag
export

Signed-off-by: leo78913 <leo3758@riseup.net>
Merge branch 'PrismLauncher:develop' into menu-icons
8db89b4
@Scrumplex Scrumplex added enhancement New feature or request ui rework labels Oct 20, 2022
@Scrumplex Scrumplex added this to the 6.0 milestone Oct 20, 2022
Scrumplex
Scrumplex approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trashcans look weird, but apart from that this looks really cool

@Scrumplex
Copy link
Member

Also, I just noticed, that most if not all Flat icons are from Material Design icons. I think we should keep it at that.

flowln
flowln approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@flowln flowln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe, now i won't need to make an icon for the rename action on the ui redesign x)

looks really cool to me, thanks!

Scrumplex
Scrumplex requested changes Oct 21, 2022
View reviewed changes
Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see above)

@leia-uwu
the trashcan icons dont look like trash now
e4b5cd2 
Signed-off-by: leo78913 <leo3758@riseup.net>
@leia-uwu
material design icons
ccf7d1e 
Signed-off-by: leo78913 <leo3758@riseup.net>
txtsd
txtsd approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@txtsd txtsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice QoL change

Scrumplex
Scrumplex approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Scrumplex Scrumplex merged commit aefb8b3 into PrismLauncher:develop Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@txtsd txtsd txtsd approved these changes

@flowln flowln flowln approved these changes

@Scrumplex Scrumplex Scrumplex approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request ui rework
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@leia-uwu @Scrumplex @txtsd @flowln