Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Configuration-less config for Qt Install #411

Merged

Conversation

TheLastRar
Copy link
Contributor

Should fix CMake install failing to copy Qt plugins when no configuration was specified when using Ninja

See #408

Signed-off-by: TheLastRar <TheLastRar@users.noreply.github.com>
@TheLastRar
Copy link
Contributor Author

Only did very quick testing, but seems to work

@DioEgizio DioEgizio added bug Something isn't working simple change labels Nov 6, 2022
Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@DioEgizio DioEgizio merged commit d558ff3 into PrismLauncher:develop Nov 7, 2022
@TheLastRar TheLastRar deleted the configurationless-install branch November 7, 2022 12:36
@Scrumplex Scrumplex added this to the 6.0 milestone Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working simple change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants