Skip to content

Commit

Permalink
Don't convert input parameters to internal type needlessly.
Browse files Browse the repository at this point in the history
Calling convert_from_base() for the input ("use") parameters was unnecessary
and potentially confusing to the client code. Simply don't do this, just as we
don't call convert_to_base() for the output ("into") parameters.

Signed-off-by: Vadim Zeitlin <vz-soci@zeitlins.org>
  • Loading branch information
vadz committed Jul 10, 2012
1 parent 2a88405 commit 22e740a
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/core/use-type.cpp
Expand Up @@ -39,7 +39,9 @@ void standard_use_type::pre_use()
void standard_use_type::post_use(bool gotData)
{
backEnd_->post_use(gotData, ind_);
convert_from_base();

// There is no need to call convert_from_base() here, the converted value
// wouldn't be used anyhow.
}

void standard_use_type::clean_up()
Expand Down

0 comments on commit 22e740a

Please sign in to comment.