From fa05838008ed89b82d0e2784e58cfd332fc8832c Mon Sep 17 00:00:00 2001 From: Mateusz Loskot Date: Sat, 2 Mar 2013 03:32:22 +0000 Subject: [PATCH] Add TODO comment for commented convert_to_base To review changes submitted in SHA: c166625a28f7c907318134f625ff5acea7d9a1f8 and currently disabled. Likely, to be removed. --- src/core/type-conversion.h | 4 ++++ src/core/use-type.h | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/core/type-conversion.h b/src/core/type-conversion.h index bf11bf0e6..38106dcd4 100644 --- a/src/core/type-conversion.h +++ b/src/core/type-conversion.h @@ -86,6 +86,7 @@ class conversion_use_type , ind_(ownInd_) , readOnly_(false) { + // TODO: likely to be removed (SHA: c166625a28f7c907318134f625ff5acea7d9a1f8) //convert_to_base(); } @@ -95,6 +96,7 @@ class conversion_use_type , ind_(ownInd_) , readOnly_(true) { + // TODO: likely to be removed (SHA: c166625a28f7c907318134f625ff5acea7d9a1f8) //convert_to_base(); } @@ -105,6 +107,7 @@ class conversion_use_type , ind_(ind) , readOnly_(false) { + // TODO: likely to be removed (SHA: c166625a28f7c907318134f625ff5acea7d9a1f8) //convert_to_base(); } @@ -115,6 +118,7 @@ class conversion_use_type , ind_(ind) , readOnly_(true) { + // TODO: likely to be removed (SHA: c166625a28f7c907318134f625ff5acea7d9a1f8) //convert_to_base(); } diff --git a/src/core/use-type.h b/src/core/use-type.h index d1e7bf873..6230cd9b1 100644 --- a/src/core/use-type.h +++ b/src/core/use-type.h @@ -50,7 +50,7 @@ class SOCI_DECL standard_use_type : public use_type_base , backEnd_(NULL) { // FIXME: This was added with Ilia's patch - // http://soci.git.sourceforge.net/git/gitweb.cgi?p=soci/soci;a=blobdiff;f=src/core/use-type.h;h=3510ac95fe7530f977bf9e78d74fd502164a4071;hp=b6d9ba9c27aef3640b8edac4b8e44a620b1b5294;hb=c166625a28f7c907318134f625ff5acea7d9a1f8;hpb=ec19564b2f0994b3960acf891643d92fc224b453 + // https://github.com/SOCI/soci/commit/c166625a28f7c907318134f625ff5acea7d9a1f8 // but it seems to be a troublemaker, causing duplicated conversions //convert_to_base(); }