HPX-thread cumulative count performance counters report incorrect value

[brycelelbach]

The cumulative HPX-thread count performance counters do not correctly count the number of executed threads; in the scheduling loop, after an HPX-thread yields or terminates back to the scheduler, the state is not checked before the counter is incremented (the state could be suspended or even pending).

[hkaiser]

Huh? Your fix changes the semantics of the performance counter. It was counting the number of executed threads before, now it counts the number of terminated threads, which is not the same. What good is it to know how many threads got eventually terminated (you have this value by querying the number of created threads)? The purpose of this was to be able to tell how often threads are invoked (executed). Please revert this change.

[pagrubel]

It is my understanding that this will be corrected by adding a counter?

[hkaiser]

Yes, we will:

• fix the documentation of the existing counter
• add a new counter returning the number of terminated (created) threads

[hkaiser]

There are still the two tasks to be fixed (see above). Thus I'm reopening the ticket.