Remove redundant costly Kleene stars from regex searches #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the string(REGEX MATCH) operations surround the pattern with ".*", causing the CMake process to effectively wedge when trying to match on larger (100KiB) bodies of input. This commit removes those parts without any change in semantics as MATCH patterns only need to match the actual match. This should fix bug STEllAR-GROUP#1040.
K-ballo
added a commit
that referenced
this pull request
Jan 6, 2014
Remove redundant costly Kleene stars from regex searches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the string(REGEX MATCH) operations surround the pattern
with ".*", causing the CMake process to effectively wedge when
trying to match on larger (100KiB) bodies of input.
This commit removes those parts without any change in semantics
as MATCH patterns only need to match the actual match.
This should fix bug #1040.