New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed minimum requirement of window install to 2012 #1102
Conversation
Grant, thanks for this. May I ask you to go further and to make the corresponding adjustments to the cmake build system as well? I think it's mainly the checks here:
which need to be adjusted (look for MSVC10 == VS2010). |
…rding 1.55.0 and msvc2013 added in docs
I ended up removing a couple if statements from the CMakeLists.txt; In the case that 2010 is disallowed they would have been redundant. I also placed the notice of 1.55.0 and MSVC2013 in the existing block below the table , I didn't want to place another 'Important' block right above the 'Notice' block as it made the page seem messy. If you have any other documentation requests please let me know, I'm happy to assist in any way while learning more about HPX. |
Boost 1.49.0), and Boost.Atomic (starting Boost 1.53.0).] | ||
Boost 1.49.0), and Boost.Atomic (starting Boost 1.53.0). It is important | ||
to note that MSVC2013 is unable to build Boost 1.55.0, a different boost | ||
version or compiler will be required.] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this is not MSVCs fault (for once). I'd suggest applying the patch from https://svn.boost.org/trac/boost/ticket/8757 as the simplest alternative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could #include <algorithm>
ourselves before any boost serialization header to work around this.
Changed minimum requirement of window install to 2012
Thanks again! |
Reflecting the recent change to README regarding the minimum version, changed docs accordingly.