Complete quoting for parameters of some CMake commands.

[elfring]

A wiki article pointed out that whitespace will only be preserved for parameters in CMake commands if passed strings will be appropriately quoted or escaped.

Quoting can be added so that more places should also handle file names correctly which contain space characters or semicolons eventually.

[hkaiser]

I'm impressed by the amount of work you put into this! Thanks a lot!

[hkaiser]

This patch causes compilation of one of the examples to fail. See here: http://hermione.cct.lsu.edu/builders/hpx_gcc46_x8664_boost152_debug/builds/306/steps/build_core/logs/stdio. Would you be able to fix this?

[elfring]

I admit that I did not test all possible software combinations for my update suggestion.

I imagine that I can not fix this unexpected build failure alone.

...
CMake Error: File /opt/buildbot/slave/hpx_gcc46_x8664_boost152_debug/build/gcc-46_boost-1520_debug/tests/performance/network/network_storage/"/opt/buildbot/slave/hpx_gcc46_x8664_boost152_debug/build/tests/performance/network/network_storage"/slurm-test-HPX-storage.sh.in does not exist.
CMake Error at /opt/buildbot/slave/hpx_gcc46_x8664_boost152_debug/build/tests/performance/network/network_storage/copy_script.cmake:4 (configure_file):
  configure_file Problem configuring file
...

It seems that the text "slurm-test-HPX-storage" is referenced at one place. (Do you know a bit more about this component?)
Do the changes for a single script trigger "this build surprise"?

[hkaiser]

The issue above seems to be fixed now, but there is another one: http://hermione.cct.lsu.edu/builders/hpx_docs/builds/172/steps/build_docs/logs/stdio which looks like is related to the quoting changes.

[elfring]

Please tell me how the issue was fixed around the "Slurm script generator".

Next issue:

• How much is your "build bot" involved here?
• When does such a tool start to pass directory names with quotation marks for a CMake variable like "HPX_SOURCE_DIR"?

[hkaiser]

Frankly, I have no idea how the issue above was solved :-P. The only change I made was to avoid that the target was built always (f75896a).

The buildbot is just a automated tool executing the build scripts, I doubt it's involved (it worked before). The variable hpx_SOURCE_DIR is set by CMake itself and is derived from the directory where the main CMakeLists.txt is located. So currently I'm a bit clueless what's causing the issue.

[elfring]

Do we need to clarify the passing of directory names with quotation marks in more detail for two build failures?

[hkaiser]

I'm not sure I understand what you mean. Could you elaborate, please?

[elfring]

Did you notice that the error messages from the two build logs mentioned directories with quotation marks in the names?
(I am also unsure at the moment where these quotes come from.)

[elfring]

Did you report build failures that are two permanent open issues at the moment?

[elfring]

I find it interesting here that you renamed an involved variable.

[elfring]

Does a specific display from your build bot indicate that my update suggestion did not damage your software generation process more than I hoped to make it a bit safer?

[elfring]

I'm sorry that I inserted a quotation mark somehow at the wrong place.

[hkaiser]

I find it interesting here that you renamed an involved variable.
Yes, this was a genuine problem. I have no idea how it could have ever worked :/

[hkaiser]

Does a specific display from your build bot indicate that my update
suggestion did not damage your software generation process more
than I hoped to make it a bit safer?
Yes, thanks again. You patch is fine, except for those problems we discussed (and where I don't even know what's causing them).