Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1d stencil examples #1133

Merged
merged 32 commits into from May 14, 2014
Merged

1d stencil examples #1133

merged 32 commits into from May 14, 2014

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented May 13, 2014

This pull request contains:

  • Further unifies the 1D example series
  • Adds a new example 1d_stencil_8
  • Adds a hpx::lcos::local::receive_buffer utility class
  • Adds a hpx::lcos::gather facility
  • Fixes the return type calculation for hpx::async_continue

Except for the hpx::lcos::gather utility this patch does not impact any documented API.

Still missing is the documentation for hpx::lcos::gather and related tests.

hkaiser and others added 23 commits May 5, 2014 17:57
@hkaiser
Restructuring examples to make them more uniform
f2d30c9
@hkaiser
Making 'current' consistently const
09e55ed
@hkaiser
Fix runtime problem in stencil_3
7257d86
@hkaiser
More work on example 8, adding lcos::local::receive_buffer
9e8a1dd
@hkaiser
Merge branch 'action_future_args' into 1d_stencil_examples
5843f91
@hkaiser
Adding missing std::move to dataflow
6521aa4
@K-ballo @hkaiser
Fixed wrong result type in unwrapped internals causing copies
970aca7
@hkaiser
Using hpx::launch::async with dataflow()
1179f54
@hkaiser
Fix code to print timing
55ab5df
@hkaiser
Adding hpx::lcos::gather(), using this in example 8, minor change to …
ac3814b 
…and_gate
@hkaiser
Adding simplest possible openmp pragmas to example 1 and 3
2f12e1f
@hkaiser
Cosmetics (suppress warnings)
f51006a
@hkaiser
Restructuring examples to make them more uniform
1b12b1e
@hkaiser
Making 'current' consistently const
e047667
@hkaiser
Fix runtime problem in stencil_3
f49c85b
@hkaiser
More work on example 8, adding lcos::local::receive_buffer
424bf9a
@hkaiser
Using hpx::launch::async with dataflow()
a4f9e48
@hkaiser
Fix code to print timing
20529c9
@hkaiser
Adding hpx::lcos::gather(), using this in example 8, minor change to …
d64464c 
…and_gate
@hkaiser
Adding simplest possible openmp pragmas to example 1 and 3
6975265
@hkaiser
Cosmetics (suppress warnings)
91b5999
@hkaiser
Merge branch '1d_stencil_examples' of github.com:STEllAR-GROUP/hpx in…
525ebaa 
…to 1d_stencil_examples
@hkaiser
Fixing remote result type calculation when using actions as continuat…
ea2118a 
…ions (async_continue)
@hkaiser hkaiser added this to the 0.9.9 milestone May 13, 2014
@StellarBot
Copy link

Tests Failed.
Refer to this link for build results: http://hermione.cct.lsu.edu:5632/job/hpx_pr_debug_gcc_44_boost_1_55_0/11/

@StellarBot
Copy link

Tests Failed.
Refer to this link for build results: http://hermione.cct.lsu.edu:5632/job/hpx_pr_debug_gcc_44_boost_1_55_0/12/

@StellarBot
Copy link

Tests Failed.
Refer to this link for build results: http://hermione.cct.lsu.edu:5632/job/hpx_pr_debug_gcc_44_boost_1_55_0/13/

@StellarBot
Copy link

Tests Failed.
Refer to this link for build results: http://hermione.cct.lsu.edu:5632/job/hpx_pr_debug_gcc_44_boost_1_55_0/14/

@hkaiser
Copy link
Member Author

hkaiser commented May 13, 2014

The remaining test failures are unrelated, this pull request is ready to be merged.

sithhell
sithhell reviewed May 13, 2014
View reviewed changes
examples/1d_stencil/1d_stencil_1.cpp
space& next = U[(t + 1) % 2];

// Uncomment the following line to use OpenMP
// #pragma omp parallel for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't a macro definition better here to control whether to use OMP here or not?

sithhell
sithhell reviewed May 13, 2014
View reviewed changes
examples/1d_stencil/1d_stencil_8.cpp
send_left(t, next[local_np-1]);
}

// Print the solution at time-step 'nt'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is probably a copy&paste leftover

@StellarBot
Copy link

Tests Failed.
Refer to this link for build results: http://hermione.cct.lsu.edu:5632/job/hpx_pr_debug_gcc_44_boost_1_55_0/15/

@StellarBot
Copy link

Tests Failed.
Refer to this link for build results: http://hermione.cct.lsu.edu:5632/job/hpx_pr_debug_gcc_44_boost_1_55_0/16/

@StellarBot
Copy link

Tests Failed.
Refer to this link for build results: http://hermione.cct.lsu.edu:5632/job/hpx_pr_debug_gcc_44_boost_1_55_0/17/

@StellarBot
Copy link

Tests Failed.
Refer to this link for build results: http://hermione.cct.lsu.edu:5632/job/hpx_pr_debug_gcc_44_boost_1_55_0/18/

@StellarBot
Copy link

Tests Failed.
Refer to this link for build results: http://hermione.cct.lsu.edu:5632/job/hpx_pr_debug_gcc_44_boost_1_55_0/19/

hkaiser added a commit that referenced this pull request May 14, 2014
@hkaiser
Merge pull request #1133 from STEllAR-GROUP/1d_stencil_examples
fb87c57 
1d stencil examples
@hkaiser hkaiser merged commit fb87c57 into master May 14, 2014
@hkaiser hkaiser deleted the 1d_stencil_examples branch May 14, 2014 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category: LCOs type: defect type: enhancement
Projects
None yet
Milestone
0.9.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hkaiser @StellarBot @sithhell @K-ballo