Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong abs() function used in example #1292

Closed
eschnett opened this issue Oct 20, 2014 · 0 comments
Closed

Wrong abs() function used in example #1292

eschnett opened this issue Oct 20, 2014 · 0 comments

Comments

@eschnett
Copy link
Contributor

I see this warning when building HPX:

/Users/eschnett/SIMFACTORY/hpx-master/src/hpx-master/examples/1d_hydro/1d_hydro_upwind.cpp:456:8: warning: using integer absolute value function 'abs' when argument is of floating point type [-Wabsolute-value]
  if ( abs(e_internal) > 0.1*middle.etot)
       ^
/Users/eschnett/SIMFACTORY/hpx-master/src/hpx-master/examples/1d_hydro/1d_hydro_upwind.cpp:456:8: note: use function 'std::abs' instead
  if ( abs(e_internal) > 0.1*middle.etot)
       ^~~
       std::abs

This seems to point to a serious issue.

@hkaiser hkaiser added this to the 0.9.9 milestone Oct 20, 2014
@hkaiser hkaiser self-assigned this Oct 20, 2014
hkaiser added a commit that referenced this issue Oct 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants