Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying parallel search algorithm for zero length searches #1373

Merged
merged 6 commits into from Feb 5, 2015
Merged

Modifying parallel search algorithm for zero length searches #1373

merged 6 commits into from Feb 5, 2015

Conversation

dcbdan
Copy link
Contributor

@dcbdan dcbdan commented Feb 4, 2015

Changed search.hpp to return the first iterator if the search iterators are the same.

@@ -66,7 +66,7 @@ namespace hpx {namespace parallel { HPX_INLINE_NAMESPACE(v1)

s_difference_type diff = std::distance(s_first, s_last);
if (diff <= 0)
return result::get(std::move(last));
return result::get(std::move(first));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this messed up the indentation. Please make sure that your editor is not inserting tabs into the files (see: https://github.com/STEllAR-GROUP/hpx/wiki/HPX-Source-Code-Structure for general coding guidelines).

@dcbdan
Copy link
Contributor Author

dcbdan commented Feb 4, 2015

Fixed my editor to use .editorconfig file. Indentation should be correct.

@hkaiser hkaiser added this to the 0.9.10 milestone Feb 4, 2015
@hkaiser
Copy link
Member

hkaiser commented Feb 4, 2015

Looks good to me.

@dcbdan dcbdan changed the title Modifying parallel search algorithm for zero length searches #1372 Modifying parallel search algorithm for zero length searches Feb 4, 2015
hkaiser added a commit that referenced this pull request Feb 5, 2015
 Modifying parallel search algorithm for zero length searches
@hkaiser hkaiser merged commit a9bb0e4 into STEllAR-GROUP:master Feb 5, 2015
@hkaiser
Copy link
Member

hkaiser commented Feb 5, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants