Parallel scan algorithms with different initial values #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt inits; minor changes for signed and unsigned int
…nt inits; minor changes for signed and unsigned int
Conflicts: hpx/parallel/algorithms/find.hpp hpx/parallel/algorithms/mismatch.hpp
|
This fixes #1390: Parallel algorithms inclusive_scan and exclusive_scan break under different initial values |
| @@ -49,11 +49,15 @@ namespace hpx { namespace parallel { HPX_INLINE_NAMESPACE(v1) | |||
| parallel(ExPolicy const& policy, InIter first, InIter last, | |||
| T const& val) | |||
| { | |||
| typedef detail :: algorithm_result<ExPolicy, InIter> result; | |||
| typedef typename std::iterator_traits<InIter>::value_type type; | |||
There was a problem hiding this comment.
Could you please stick to the code formatting we use everywhere else (i.e. no spaces surrounding ::)?
|
Very nicely done! Thanks! I'm fine with merging this. |
hkaiser
added a commit
that referenced
this pull request
Mar 6, 2015
Parallel scan algorithms with different initial values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied fix to inclusive_scan, exclusive_scan, transform_inclusive_scan, transform_exclusive_scan to work with different intial values. Also made quick changes to copy and find.