Always stripping HPX command line arguments before executing start function #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, thanks! |
| std::string const& /*app_name*/, int argc, char** argv, hpx::runtime_mode mode) | ||
| inline int | ||
| init(util::function_nonser<int(int, char**)> const& f, | ||
| std::string const& /*app_name*/, int argc, char** argv, |
There was a problem hiding this comment.
Why is the app_name not passed here? If it isn't used anyway, can't we remove it?
There was a problem hiding this comment.
Good point. It was of no use for the old code but can now be utilized. I'll add that. OTOH, removing it wouldn't do any harm either...
sithhell
added a commit
that referenced
this pull request
Apr 1, 2015
Always stripping HPX command line arguments before executing start function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #1437: hpx::init() should strip HPX-related flags from argv