Docker image generation #1484
Docker image generation #1484
Conversation
|
I will still need to add documentation, but this branch should be merged with master before we modify circle.yml. |
| # http://3ofcoins.net/2013/09/22/flat-docker-images/ | ||
| # | ||
| # TODO: replace with something homemade | ||
|
|
There was a problem hiding this comment.
Please add the Boost License header
There was a problem hiding this comment.
U sure? We don't even have the copyright for this file, I pulled it in from that dude. He published it via gist without copyright note
There was a problem hiding this comment.
He added his copyright but published it without a license (which means it's in the public domain). That entitles us to relicense it under the Boost license, I don't see a problem with that.
There was a problem hiding this comment.
Well, technically he didn't even add his name in, I did that ;)
Should I strip his name out? Or is it polite to leave that in
There was a problem hiding this comment.
I'd leave his copyright in place, credit where credit is due...
|
LGTM, please go ahead and merge. |
This branch will create a docker image with hpx installed on it.
This could be used for rapid prototyping, external unit tests, writing minimal examples that reproduce errors, potential deployment in the cloud, continuous integration for external projects (like hpxcl), etc.