Making detail::condition_variable safe to use #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since #1488, the semantics of locks used with detail::cv where changed in a way that is difficult to handle correctly with Lockables that do not represent ownership. To avoid this fragile scenario, detail::cv now only accepts `boost::unique_lock`s, which are known to be safe.
… to make the new requirements of detail::cv explicit
Calls to detail::cv notification functions will now always leave the lock unlocked. Reacquiring the lock is often unnecessary, and leaving it unlocked gives the notified thread a better chance to resume work immediately rather than having to wait for a locked mutex. To make the transfer of the lock ownership explicit, those functions now take the lock by value.
|
LGTM |
K-ballo
added a commit
that referenced
this pull request
May 21, 2015
Making detail::condition_variable safe to use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor redesign of how locks are handled by
detail::condition_variable: