Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit async/apply SFINAE conditions #1558

Merged
merged 4 commits into from May 28, 2015
Merged

Revisit async/apply SFINAE conditions #1558

merged 4 commits into from May 28, 2015

Conversation

K-ballo
Copy link
Member

@K-ballo K-ballo commented May 28, 2015

No description provided.

The `is_action` trait required a complete type in its defaulted template argument. This caused unnecessary instantiations when used in async/apply SFINAE checks, even when there is an explicit specialization for a particular action type. Delaying the base template implementation delays instantiations, which are avoided if a specialization is preferred.
Fix checked conditions, and reimplement them as multi-step SFINAE.
@hkaiser
Copy link
Member

hkaiser commented May 28, 2015

LGTM

hkaiser added a commit that referenced this pull request May 28, 2015
Revisit async/apply SFINAE conditions
@hkaiser hkaiser merged commit b893cd9 into master May 28, 2015
@hkaiser hkaiser deleted the async-sfinae branch May 28, 2015 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants