Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leftover HPX_REGISTER_ACTION_DECLARATION_2 #1560

Closed
AntonBikineev opened this issue May 28, 2015 · 4 comments
Closed

Leftover HPX_REGISTER_ACTION_DECLARATION_2 #1560

AntonBikineev opened this issue May 28, 2015 · 4 comments

Comments

@AntonBikineev
Copy link
Contributor

After moving action serialization to new library we don't need to have this macro anymore.
https://github.com/STEllAR-GROUP/hpx/blob/master/hpx/runtime/actions/basic_action.hpp#L504-L505

@hkaiser
Copy link
Member

hkaiser commented May 28, 2015

What about HPX_REGISTER_ACTION_DECLARATION_, HPX_REGISTER_ACTION_DECLARATION_1 and possibly others?

@hkaiser
Copy link
Member

hkaiser commented May 28, 2015

The actual question is: should we completely remove the two-argument version of HPX_REGISTER_ACTION_DECLARATION? This would be a breaking change and would require modification of a lot of code out there.

@sithhell
Copy link
Member

sithhell commented May 28, 2015 via email

@hkaiser
Copy link
Member

hkaiser commented Jun 13, 2015

I'll close this for now as the consensus seems to be to leave the macro in place. Please reopen if there are concerns.

@hkaiser hkaiser closed this as completed Jun 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants