New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake fails when CMAKE_BINARY_DIR contains '+'. #1590
Comments
That's a bummer. I wouldn't even know how to fix this at this point. But I'm no cmake guru to begin with... |
Is this a cmake problem or a problem on our side? Do other projects work
living under the `c++` directory using cmake?
|
The problem is that the CMAKE_BINARY_DIR is used as the match in a regex and as it contains a "++" cmake (correctly) thinks that this is part of the regex control sequence. Applying a string replace of "++" with " |
Wouldn't other special regex characters cause the same issues? |
Yes, the '.' and '$' are most likely to be encountered in path names. The '.' will match itself and if a problem is reported with another char, we can look again at a more general fix. excerpt from cmake docs |
We should probably create a ticket for this. While you nicely 'unbroke' the user's code, your patch has not really 'fixed' the issue. |
I'll fix it properly when I have a spare moment. |
- This fixes #1590: CMake fails when CMAKE_BINARY_DIR contains '+'
- This fixes #1590: CMake fails when CMAKE_BINARY_DIR contains '+'
Getting the following error message:
Renaming the folder 'c++' to 'cpp' will let CMake run successfully.
The text was updated successfully, but these errors were encountered: