Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring thread manager, mainly extracting thread pool #1609

Merged
merged 1 commit into from Jun 21, 2015

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Jun 14, 2015

This patch separates the thread-pool functionality from the thread-manager. This is the first step towards creating an executor which has full control over processing units. The existing executors are built on top of the underlying main scheduler, which causes them to compete for processing time. The new executor will not have that disadvantage.

@pagrubel
Copy link
Member

@hkaiser
Copy link
Member Author

hkaiser commented Jun 15, 2015

See error: https://www.dropbox.com/s/54jhspdlos7g597/makeerr?dl=0

Thanks, that's fixed now.

@pagrubel
Copy link
Member

Running some performance tests

@pagrubel
Copy link
Member

Performance unchanged on host computers but the mic is much slower, let me see if this is the branch or somewhere else I have not checked this in a while

@hkaiser
Copy link
Member Author

hkaiser commented Jun 16, 2015

Performance unchanged on host computers but the mic is much slower, let me see if this is the branch or somewhere else I have not checked this in a while

Thanks. Since I have not changed anything besides splitting the two classes I would have expected to see no performance difference.

@pagrubel
Copy link
Member

Looks good to me. Just wondering why the change to integer from unsigned int

@hkaiser
Copy link
Member Author

hkaiser commented Jun 16, 2015

Just wondering why the change to integer from unsigned int

This is to cleanup the return value for performance counters. It always was int64_t. However, for some reason some of the performance counter functions did return uint64_t. This is more of a fly-by change, unrelated to the refactoring itself.

@pagrubel
Copy link
Member

I figured it wasn’t part of the refactoring and was just curious. Thanks

hkaiser added a commit that referenced this pull request Jun 21, 2015
Refactoring thread manager, mainly extracting thread pool
@hkaiser hkaiser merged commit bb00a12 into master Jun 21, 2015
@hkaiser hkaiser deleted the refactor_thread_manager branch June 21, 2015 16:23
hkaiser added a commit that referenced this pull request Jun 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants