Fixing held locks #1697
Merged
Fixing held locks #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lder for polymorphic tests
| @@ -300,8 +301,11 @@ namespace detail | |||
| wait(ec); | |||
| if (ec) return NULL; | |||
|
|
|||
| boost::unique_lock<mutex_type> l(mtx_); | |||
There was a problem hiding this comment.
This lock is unnecessary. Once a future has been made ready, which is a postcondition of wait, either:
- there is only one writer (
future), or - there are multiple readers only (
shared_future, lock hurts concurrency)
There was a problem hiding this comment.
Ok, let's remove it again. I was not sure...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the current locking problems.
@K-ballo could you please review the changes?