Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile only tests #1710

Merged
merged 17 commits into from Sep 14, 2015
Merged

Compile only tests #1710

merged 17 commits into from Sep 14, 2015

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Aug 7, 2015

Simplify the creation of compile-only tests in the build system

# file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)

# collect a list of all header files in the source tree
file(GLOB_RECURSE headers "${PROJECT_SOURCE_DIR}/hpx/*hpp")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably exclude everything in directories in "detail" directories, those are not meant to be included by anyone knowing exactly what they do anyways.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, will do.

@sithhell
Copy link
Member

I think we should run those tests in circle-ci to catch those errors before hitting master.

@hkaiser
Copy link
Member Author

hkaiser commented Aug 10, 2015

I think we should run those tests in circle-ci to catch those errors before hitting master.

Good point. Lot'sa work fixing those, though...

@hkaiser hkaiser force-pushed the compile_only_tests branch 4 times, most recently from 82d22a9 to 9b43dcd Compare August 15, 2015 17:19
Conflicts:
	docs/CMakeLists.txt
	hpx/config.hpp
	hpx/config/defaults.hpp
	hpx/hpx_fwd.hpp
	hpx/lcos/async_callback_fwd.hpp
	hpx/lcos/detail/async_colocated_fwd.hpp
	hpx/lcos/detail/async_implementations.hpp
	hpx/runtime/actions/basic_action.hpp
	hpx/runtime/serialization/container.hpp
	hpx/runtime/threads/thread_executor.hpp
	hpx/runtime/threads/thread_helpers.hpp
	hpx/traits/is_launch_policy.hpp
Attempt to fix windows build problems
 - Adding hpx_fwd.hpp to the parse_slurm_nodelist.hpp to avoid
   asio to error out
@sithhell
Copy link
Member

I am going to merge this PR now. The only remaining issue is documented here: #1748

sithhell added a commit that referenced this pull request Sep 14, 2015
@sithhell sithhell merged commit 0d979fe into master Sep 14, 2015
@sithhell sithhell deleted the compile_only_tests branch September 14, 2015 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants