Parallel composition with generic containers #1739
Conversation
…r type has some function
|
K-ballo: I addressed some of your comments, hkaiser: if you have time, please review |
@AntonBikineev only some? Which ones have you ignored? |
| @@ -104,6 +104,9 @@ namespace hpx { namespace traits | |||
| struct default_chunk_size; | |||
|
|
|||
| /////////////////////////////////////////////////////////////////////////// | |||
| template <typename Range> | |||
| struct is_range; | |||
There was a problem hiding this comment.
I'd suggest making the is_range trait SFINAE friendly by giving it an typename Enable = void argument, similar to all the other traits.
|
@K-ballo : I ignored the one about template template parameter with variadic parameter in test file for now |
|
@K-ballo : the when_all test worked fine for gcc-4.6, yet it didn't compile for intel |
AntonBikineev
force-pushed
the
parallel_composition_with_generic_containers
branch
from
10a224d
to
71730be
Compare
AntonBikineev
assigned AntonBikineev and aserio and unassigned AntonBikineev and aserio
|
LGTM, needs re-basing against master, though. |
|
@hkaiser: why rebasing, not merging? |
|
Sure, I meant merge |
|
Is somebody reviewing this? |
|
LGTM |
…_generic_containers Parallel composition with generic containers
|
@AntonBikineev This is causing build failures on Intel compilers (see here), those failures appear to be those I warned about and you confirmed broken. Please take another look at them, it should be enough to use a concrete template argument instead of a template template argument. |
Started working on functionality which was taken from National Body Comments https://isocpp.org/files/papers/N4551.pdf.
Added functionality for specifying resulting container type for when_all, when_any, when_some.