Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #1757 #1758

Merged
merged 2 commits into from Sep 23, 2015
Merged

Fixing #1757 #1758

merged 2 commits into from Sep 23, 2015

Conversation

sithhell
Copy link
Member

This patch should fix the errors described in #1757.
@pagrubel, @khuck: Can you please confirm?

@@ -585,7 +585,7 @@ namespace hpx

std::size_t get_pu_offset(util::command_line_handling const& cfg)
{
std::size_t pu_offset = 0;
std::size_t pu_offset = -1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires a static_cast<std::size_t>(-1) to avoid a warning.

@hkaiser
Copy link
Member

hkaiser commented Sep 23, 2015

Otherwise, LGTM.

@pagrubel
Copy link
Member

This looks good now, please merge it.

hkaiser added a commit that referenced this pull request Sep 23, 2015
@hkaiser hkaiser merged commit fba0a4a into master Sep 23, 2015
@hkaiser hkaiser deleted the fixing_1757 branch September 23, 2015 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants