Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing 1763 #1764

Closed
wants to merge 3 commits into from
Closed

Fixing 1763 #1764

wants to merge 3 commits into from

Conversation

AntonBikineev
Copy link
Contributor

No description provided.

@AntonBikineev
Copy link
Contributor Author

operator new(size_t) is useless because when calling new thread_data lookup doesn't go to outmost namespaces and overload resolution says no, no overload

@K-ballo
Copy link
Member

K-ballo commented Sep 26, 2015

The "won't be called" stuff that actually "might be called" makes me uneasy. If those certainly won't be called, and given that's a requirement for the program to be well-formed, why not enforcing that requirement by the design?

@AntonBikineev
Copy link
Contributor Author

@K-ballo ugh, the first point is absolutely correct, thanks.
In what scenarios that operator new(size_t) "might be called"? What do you suggest? I personally don't like those run-time assertions and would rather prefer having it deleted and link-time errors.

@hkaiser
Copy link
Member

hkaiser commented Sep 27, 2015

@AntonBikineev can we close this now?

@AntonBikineev
Copy link
Contributor Author

@hkaiser think so

@hkaiser hkaiser closed this Sep 27, 2015
@hkaiser hkaiser deleted the fixing_1763 branch September 27, 2015 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants