Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlinks generated by inspect tool are wrong #1817

Closed
hkaiser opened this issue Oct 24, 2015 · 2 comments
Closed

Hyperlinks generated by inspect tool are wrong #1817

hkaiser opened this issue Oct 24, 2015 · 2 comments

Comments

@hkaiser
Copy link
Member

hkaiser commented Oct 24, 2015

The newly introduced hyperlinks generated by the inspect tool generate a http 404 error. For an example see: https://circle-artifacts.com/gh/STEllAR-GROUP/hpx/1920/artifacts/0/tmp/circle-artifacts.NZ8Xs7y/hpx_inspect_report.html.

@Bcorde5: would you be able/willing to look into this?

@hkaiser
Copy link
Member Author

hkaiser commented Oct 26, 2015

@Bcorde5: There are more issues with the current link generation:

  • The following checkers do not add the generated hyperlink to the error:
    • apple_macro_check
    • ascii_check
  • There are still many lines in the inspect source code which are longer than 90 characters

@hkaiser
Copy link
Member Author

hkaiser commented Nov 7, 2015

This has been fixed by #1823: Adding git commit id to circleci build

@hkaiser hkaiser closed this as completed Nov 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant