New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing most usage of Boost.Config #1877
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This decouples the HPX compile time configuration from that of boost. This removes the include order dependency between boost.config and hpx. - replaced all Boost.Config related macro definitions with the equivalent HPX macros - Boost config macros used for OS Thread API selection are untouched
Conflicts: hpx/util/detail/basic_function.hpp hpx/util/detail/function_template.hpp hpx/util/detail/unique_function_template.hpp
Conflicts: hpx/util/plugin/dll.hpp hpx/util/plugin/virtual_constructor.hpp hpx/util/thread_specific_ptr.hpp hpx/util/time_logger.hpp hpx/util/value_logger.hpp tests/performance/local/native_tls_overhead.cpp
@sithhell What's the status of this PR? |
Conflicts: hpx/lcos/local/dataflow.hpp hpx/runtime/naming/name.hpp hpx/runtime/serialization/access.hpp
I just merged master onto that branch, should be good now. |
sithhell
force-pushed
the
remove_boost_config
branch
from
December 17, 2015 10:51
75c6917
to
b85d9fd
Compare
This compiles fine on MSVC, LGTM. |
sithhell
added a commit
that referenced
this pull request
Dec 17, 2015
Removing most usage of Boost.Config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decouples the HPX compile time configuration from that of boost. This
removes the include order dependency between boost.config and hpx.
HPX macros