Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serialization of std::array appears broken in latest commit #1923

Closed
dmarce1 opened this issue Dec 21, 2015 · 9 comments · Fixed by #1926
Closed

serialization of std::array appears broken in latest commit #1923

dmarce1 opened this issue Dec 21, 2015 · 9 comments · Fixed by #1926

Comments

@dmarce1
Copy link
Member

dmarce1 commented Dec 21, 2015

When compiling octotiger dmarce1/octotiger@049ee7e with HPX 1e54260, I get the error messages here: https://gist.github.com/dmarce1/cda50131e87350e34f29, which seem to indicate a problem with std::array serialization.

@AntonBikineev
Copy link
Contributor

let me look into that at night

@hkaiser
Copy link
Member

hkaiser commented Dec 21, 2015

@dmarce1 Are you sure you have #include <hpx/includes/serialization.hpp> in the source files in question?

@AntonBikineev
Copy link
Contributor

or at some point in your sources you should include <hpx/runtime/serialization/array.hpp>

@dmarce1
Copy link
Member Author

dmarce1 commented Dec 21, 2015

I do not have hpx/includes/serialization.hpp included, but I do have hpx/runtime/serialization/serialize.hpp and hpx/runtime/serialization/array.hpp.

@hkaiser
Copy link
Member

hkaiser commented Dec 21, 2015

AFAICS, the file grid.hpp does not include any of the HPX serialization headers.

@dmarce1
Copy link
Member Author

dmarce1 commented Dec 21, 2015

The headers are in defs.hpp

@hkaiser
Copy link
Member

hkaiser commented Dec 22, 2015

From the fix (#1926) we can see that serializing std::array has never worked :/ - isn't that amazing?

@AntonBikineev
Copy link
Contributor

@hkaiser, it's just my bad

@hkaiser
Copy link
Member

hkaiser commented Dec 22, 2015

@AntonBikineev please don't worry about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants